-
Notifications
You must be signed in to change notification settings - Fork 157
cam6_4_076: Change cam7 testing to use MOM t232 mask. #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we (should we?) change all ne30pg3_ne30pg3_mg17
tests to ne30pg3_ne30pg3_mt232
, and not just aux_cam / prealpha tests? I'm referring to these carma, aux_pumas, waccm, camchem, zmean_nudging categories in testlist_cam.xml
. I think it would make sense to convert these all at once.
Hi Adam. I've been trying to take a more incremental approach so that I don't bother changing tests now that may just end up being removed. Also, with respect to this particular PR, I may need to turn this around quickly with an update to the ccs_config_cesm external further than what I currently need. So I'd prefer not to add more test changes right now. |
Since not all the tests are being updated right now, should we make sure to keep the issue open (change the "resolves" to "partial updates" or open an new issue? |
I'll open a new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but reminding that we need a new issue to replace the one which this PR is closing.
Merge pull request ESCOMP#1246 from brian-eaton/masks cam6_4_076: Change cam7 testing to use MOM t232 mask. ESCOMP commit: 068d59b
Resolves #1236 - Change our testing from using the POP land/ocean mask to the MOM t232 land/ocean mask
use ne30pg3_ne30pg3_mt232.
updated to use f19_f19_mg17.